Skip to content

feat: included pairspaces feature #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

feat: included pairspaces feature #587

wants to merge 4 commits into from

Conversation

@declanjryan
Copy link

@declanjryan declanjryan commented Aug 11, 2025 •
edited
Loading

What type of PR is this?

Update to an existing dev container collection

Related Issues

NA

Description

Includes a new DevContainer Feature that provides the PairSpaces CLI to Devcontainers.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

NA

@declanjryan declanjryan requested a review from a team as a code owner August 11, 2025 03:06
Kaniska244
Kaniska244 suggested changes Oct 27, 2025
View reviewed changes
Copy link

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @declanjryan

Apologies for the delay. Would you please resolve the conflict.

@declanjryan
Copy link
Author

declanjryan commented Oct 27, 2025

Thanks @Kaniska244! I merged latest and it should be good for you to approve now.

AlvaroRausell
AlvaroRausell requested changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Your oci reference is not resolving to any ghcr page, and instead returning a 404. Can you make sure it is set up? Thanks!

@declanjryan
Copy link
Author

declanjryan commented Oct 27, 2025

Thanks @AlvaroRausell ! I merged latest and updated the OCI reference. The following works, but let me know if I need to change something.

> docker pull ghcr.io/pairspaces/devcontainers/pairspaces || true
Using default tag: latest
latest: Pulling from pairspaces/devcontainers/pairspaces
29e20719b54a: Download complete 
44136fa355b3: Download complete 
Digest: sha256:d038834d7e9201a820c2b2f9c1edf60a45ef413547046144abdf98f2887af032
Status: Downloaded newer image for ghcr.io/pairspaces/devcontainers/pairspaces:latest
ghcr.io/pairspaces/devcontainers/pairspaces:latest

@declanjryan declanjryan force-pushed the feat/included-pairspaces branch from 1845ae2 to 3c7cd88 Compare October 27, 2025 19:37
@AlvaroRausell
Copy link
Contributor

AlvaroRausell commented Nov 20, 2025

@declanjryan all good now! For some reason, I do not have write access to your fork. I need this in order to approve the PR

@declanjryan
Copy link
Author

declanjryan commented Nov 20, 2025

Thanks @AlvaroRausell! I'm not sure why it's not public either, but I added you with write permissions and synced with latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlvaroRausell AlvaroRausell AlvaroRausell requested changes

+1 more reviewer

@Kaniska244 Kaniska244 Kaniska244 requested changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@declanjryan @AlvaroRausell @Kaniska244